Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/9055#discussion_r42583339
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -1485,14 +1490,39 @@
https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation%2C+Cube%2C
val BETWEEN = "(?i)BETWEEN".r
val WHEN = "(?i)WHEN".r
val CASE = "(?i)CASE".r
-
- protected def nodeToExpr(node: Node): Expression = node match {
+ val EXISTS = "(?i)EXISTS".r
+
+ protected def nodeToExpr(node: Node, context: Context): Expression =
node match {
--- End diff --
We don't use the `context` in this PR, however, the `def nodeToPlan(..)`
need the `context`, as in this implementation, I actually add 2 extra
expressions, they take the `LogcialPlan` as parameters, which mean the function
`nodeToExpr` will call `nodeToPlan()` and pass the `context` down. Otherwise I
have to pass the `null` to `nodeToPlan()`, which probably even more confusing
and error-prone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
