Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/962#discussion_r14215195
--- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
---
@@ -457,9 +483,13 @@ class JsonProtocolSuite extends FunSuite {
new TaskInfo(a, b, c, "executor", "your kind sir",
TaskLocality.NODE_LOCAL)
}
- private def makeTaskMetrics(a: Long, b: Long, c: Long, d: Long, e: Int,
f: Int) = {
+ /**
+ * Creates a TaskMetrics object describing a task that read data from
HDFS (if hasHdfsInput is
+ * set to true) or read data from a shuffle otherwise.
+ */
+ private def makeTaskMetrics(
+ a: Long, b: Long, c: Long, d: Long, e: Int, f: Int, hasHdfsInput:
Boolean) = {
--- End diff --
same nit as above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
