Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9203#discussion_r42688421
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/GenerateColumnAccessor.scala
---
@@ -20,18 +20,42 @@ package org.apache.spark.sql.columnar
import org.apache.spark.Logging
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions._
-import org.apache.spark.sql.catalyst.expressions.codegen.{CodeFormatter,
CodeGenerator}
+import org.apache.spark.sql.catalyst.expressions.codegen.{UnsafeRowWriter,
CodeFormatter, CodeGenerator}
import org.apache.spark.sql.types._
/**
- * An Iterator to walk throught the InternalRows from a CachedBatch
+ * An Iterator to walk through the InternalRows from a CachedBatch
*/
abstract class ColumnarIterator extends Iterator[InternalRow] {
- def initialize(input: Iterator[CachedBatch], mutableRow: MutableRow,
columnTypes: Array[DataType],
+ def initialize(input: Iterator[CachedBatch], columnTypes:
Array[DataType],
columnIndexes: Array[Int]): Unit
}
/**
+ * An helper class to update the fields of UnsafeRow, used by
ColumnAccessor
--- End diff --
should put a giant warning here that writes must be in increasing order of
ordinals
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
