Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9197#discussion_r42699555
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala 
---
    @@ -70,12 +71,30 @@ private[netty] class NettyRpcEnv(
       // Because TransportClientFactory.createClient is blocking, we need to 
run it in this thread pool
       // to implement non-blocking send/ask.
       // TODO: a non-blocking TransportClientFactory.createClient in future
    -  private val clientConnectionExecutor = 
ThreadUtils.newDaemonCachedThreadPool(
    +  private[netty] val clientConnectionExecutor = 
ThreadUtils.newDaemonCachedThreadPool(
         "netty-rpc-connection",
         conf.getInt("spark.rpc.connect.threads", 64))
     
       @volatile private var server: TransportServer = _
     
    +  private val stopped = new AtomicBoolean(false)
    +
    +  /**
    +   * A map for [[RpcAddress]] and [[Outbox]]. When we are connecting to a 
remote [[RpcAddress]],
    +   * we just put messages to its [[Outbox]] to implement a non-block 
`send` method.
    --- End diff --
    
    nit: non-blocking


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to