Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9203#discussion_r42703195
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -124,17 +124,10 @@ object GenerateUnsafeProjection extends
CodeGenerator[Seq[Expression], UnsafePro
"""
case _ if ctx.isPrimitiveType(dt) =>
- val fieldOffset = ctx.freshName("fieldOffset")
s"""
- final long $fieldOffset = $rowWriter.getFieldOffset($index);
- Platform.putLong($bufferHolder.buffer, $fieldOffset, 0L);
- ${writePrimitiveType(ctx, input.value, dt,
s"$bufferHolder.buffer", fieldOffset)}
+ $rowWriter.write($index, ${input.value});
"""
- case t: DecimalType if t.precision <= Decimal.MAX_LONG_DIGITS =>
--- End diff --
it won't matter as much, since the branch predictor can mostly eliminate
them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
