Github user sun-rui commented on the pull request:

    https://github.com/apache/spark/pull/9179#issuecomment-150137114
  
    @shivaram, some thought on the naming consistency of options.
    For pySpark, the name convention is spark.python.xxx, for example, 
spark.python.profile
    And we a documented SparkR config option, that is: 
spark.r.numRBackendThreads
    
    in this PR, the names of the two options to be documented are:
    "spark.sparkr.r.driver.command" and "spark.sparkr.r.command"
    
    I am thinking rename them to
    "spark.r.driver.rscript" and "spark.r.rscript" for better naming 
consistency. 
    
    There is backward compatibility issue for renaming "spark.sparkr.r.command" 
to "spark.r.rscript", but I think since it is not documented before, it won't 
cost too much.
    
    If you have no strong preference for this thought, you can merge this PR.
    If you agree, I can update this PR.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to