Github user ckadner commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6983#discussion_r42723887
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
 ---
    @@ -324,20 +324,6 @@ class HiveQuerySuite extends HiveComparisonTest with 
BeforeAndAfter {
           | FROM src LIMIT 1
         """.stripMargin)
     
    -  createQueryTest("Date comparison test 2",
    -    "SELECT CAST(CAST(0 AS timestamp) AS date) > CAST(0 AS timestamp) FROM 
src LIMIT 1")
    --- End diff --
    
    ```
      override def beforeAll() {
        ...
        TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles"))
    ```
    
    - before my fix, both Spark (1.4) and Hive (0.13) returned `true`
    - after my fix, Spark (1.5) returned `false` and Hive (0.13) returned 
`true` (that's why we removed it)
    - since Spark (1.5) later moved to Hive 1.2.1 now, both Spark and Hive 
return `false`
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to