Github user dragos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8872#discussion_r42725306
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
 ---
    @@ -443,9 +444,13 @@ private[spark] class MesosClusterScheduler(
         options
       }
     
    -  private class ResourceOffer(val offer: Offer, var cpu: Double, var mem: 
Double) {
    +  private class ResourceOffer(
    +      val offerId: OfferID,
    +      val slaveId: SlaveID,
    +      var resources: JList[Resource],
    +      var used: Boolean) {
    --- End diff --
    
    I'd avoid mutable fields for little classes like this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to