Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/900#discussion_r14225485
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -244,6 +255,17 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, actorSystem: A
throw new SparkException("Error notifying standalone scheduler's
driver actor", e)
}
}
+
+ override def isReady(): Boolean = {
+ if (ready) {
--- End diff --
Based on my experience profiling the Spark scheduler, things like this do
not affect performance in any significant way and in practice are often
optimized out by JIT anyway, so we should opt for the more readable version
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
