Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-150325385
@mengxr Could you take a look?
@feynmanliang These changes clash with some of your changes in
https://github.com/apache/spark/pull/8648, sorry, because I simplified the
interface of ActivationFunction to `Double => Double` and forced all
computations to be in place. However, your suggestion of `UFunc` could be very
helpful. Can you think of a way rewriting the `UniversalFunction` object with
`UFunc` so that it does in-place operations? In any case, we have to merge your
changes in `BreezeUtil.scala` either in the original PR or here and improve the
scaladoc as you proposed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
