Github user FRosner commented on the pull request:
https://github.com/apache/spark/pull/9222#issuecomment-150494394
@sun-rui so there is an existing R test case for this method? In the end I
just did a refactoring so existing tests should not break.
The idea of unit tests however is to test one thing. A unit test for a
method should test exactly what this method is doing and not other related
things like serde. If serde breaks, you still want to test for this method to
succeed, because it is working. And since it is public API, anyone using Spark
can use it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
