Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9244#discussion_r42853708
--- Diff: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala ---
@@ -73,7 +74,8 @@ object SizeEstimator extends Logging {
private val ALIGN_SIZE = 8
// A cache of ClassInfo objects for each class
- private val classInfos = new ConcurrentHashMap[Class[_], ClassInfo]
+ // We use weakKeys to allow GC of dynamically created classes
+ private val classInfos = new MapMaker().weakKeys().makeMap[Class[_],
ClassInfo]()
--- End diff --
Rather than involve Guava, this can just be a `WeakHashMap`? it has weak
keys.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
