Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8652#discussion_r42893820
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -268,6 +268,27 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
object CartesianProduct extends Strategy {
def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
+ // Not like the equal-join, BroadcastNestedLoopJoin doesn't support
condition
+ // for cartesian join, as in cartesian join, probably, the records
satisfy the
+ // condition, but exists in another partition of the large table, so
we may not able
+ // to eliminate the duplicates.
--- End diff --
Does this comment related to this case? Also, I still do not think these
two rules should be in this Strategy because the name of this strategy is
`CartesianProduct`, but these first two cases are not for `CartesianProduct`.
Actually, can we combine `CartesianProduct` and `BroadcastNestedLoopJoin`
strategies?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
