Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9127#discussion_r42897971
  
    --- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala 
---
    @@ -42,8 +60,10 @@ private[spark] abstract class MemoryManager extends 
Logging {
       }
     
       // Amount of execution/storage memory in use, accesses must be 
synchronized on `this`
    -  protected var _executionMemoryUsed: Long = 0
    -  protected var _storageMemoryUsed: Long = 0
    +  @GuardedBy("this") protected var _executionMemoryUsed: Long = 0
    +  @GuardedBy("this") protected var _storageMemoryUsed: Long = 0
    +  // Map from taskAttemptId -> memory consumption in bytes
    +  @GuardedBy("this") private val memoryConsumptionForTask = new 
mutable.HashMap[Long, Long]()
    --- End diff --
    
    `executionMemoryForTask`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to