Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-150658089
Patch with revert posted
For reviewers, here some things to consider
1. Which exceptions should trigger log & skip for token, vs which are
critical enough to fail the process. The patch ignores no classpath found
(`NoClassDefFoundError` and `ClassNotFoundException`) (i.e. hive not on the
CP), but also `NoSuchMethodException`. Which means that even if the security
settings require a token, if there's some method incompatibility, it will be
ignored.
1. the Hadoop config now passed down is used to help define the hive
configuration used in the binding. This is needed for testing. Previously, an
empty `HiveConf` instance was created: enough to force in the hive-default.xml
and hive-site.xml, but not able to pick on any custom options. This is a
change: does it constitute a regression, or a feature?
Also, I've just realised the final`closeCurrent()` call must be in a
finally(); will add
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
