Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9127#discussion_r42905961
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
@@ -87,6 +88,7 @@ import org.apache.spark.storage.{BlockId,
DiskBlockObjectWriter}
* - Users are expected to call stop() at the end to delete all the
intermediate files.
*/
private[spark] class ExternalSorter[K, V, C](
+ context: TaskContext,
--- End diff --
Also, having it default doesn't buy us much, since we'd still need to
update the other call-sites because positional arguments have now changed. I
suppose we could also swap the ordering of arguments. I'd like to just leave
this as-is, though; it's not a big deal to pass it explicitly at the one or two
call sites.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
