Github user FRosner commented on the pull request:
https://github.com/apache/spark/pull/9222#issuecomment-150778118
@sun-rui thanks for your comments. You should not hesitate to add unit
tests for functions that are not tested, yet. Tests help other developers (like
me) to change stuff in the code without the immediate fear of unforseen
consequences. They also document the API. As this function is public, it should
have a test.
I will look into the build failure reason now @shivaram. I was not able to
run all tests locally as I got out of memory problems, although I changed the
maven settings as indicated in the documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
