Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/8840#discussion_r42942564
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -128,30 +136,32 @@ private[sql] object PartitioningUtils {
private[sql] def parsePartition(
path: Path,
defaultPartitionName: String,
- typeInference: Boolean): Option[PartitionValues] = {
+ typeInference: Boolean): (Option[PartitionValues], Option[Path]) = {
--- End diff --
A base path is not always associated with a `PartitionValues`. If there is
no partition, we can still have a base path.
That is why I don't make `case class PartitionValues(columnNames:
Seq[String], literals: Seq[Literal])` to something like `case class
PartitionValues(path: String, columnNames: Seq[String], literals:
Seq[Literal])`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
