Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9232#discussion_r42952965
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtilSuite.scala
---
@@ -245,4 +247,28 @@ class YarnSparkHadoopUtilSuite extends SparkFunSuite
with Matchers with Logging
System.clearProperty("SPARK_YARN_MODE")
}
}
+
+ test("Obtain tokens For HiveMetastore") {
+ val hadoopConf = new Configuration()
+ hadoopConf.set("hive.metastore.kerberos.principal", "bob")
+ // thrift picks up on port 0 and bails out, without trying to talk to
endpoint
+ hadoopConf.set("hive.metastore.uris", "http://localhost:0";)
+ val util = new YarnSparkHadoopUtil
+ val e = intercept[InvocationTargetException] {
+ val token = util.obtainTokenForHiveMetastoreInner(hadoopConf,
"alice")
+ fail(s"Expected an exception, got the token $token")
--- End diff --
As with the case below, I fail to see how the token can help in figuring
out what was wrong. If a token is returned, you kinda know what it will be
already. You're testing the fact that a token should not be returned at all,
and an exception thrown instead. If the exception is not thrown (or the wrong
one), that's the problem, and the returned token won't help in figuring out why.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
