Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9233#discussion_r42958927
--- Diff: python/pyspark/ml/classification.py ---
@@ -490,7 +411,7 @@ class
RandomForestClassificationModel(TreeEnsembleModels):
@inherit_doc
class GBTClassifier(JavaEstimator, HasFeaturesCol, HasLabelCol,
HasPredictionCol, HasMaxIter,
- DecisionTreeParams, HasCheckpointInterval):
+ GBTParams, HasCheckpointInterval, HasStepSize):
--- End diff --
Should be also extend ```TreeClassifierParams```? I know currently only
```impurity``` in ```TreeClassifierParams``` and
```GBTClassifier.setImpurity``` should NOT be used, but I think we should keep
the same inheritance relationships between Scala & Python. May be one day we
will have more params in ```TreeClassifierParams`` and ```GBTClassifier``` will
use those params.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
