Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9190#discussion_r42970368
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/tuples.scala 
---
    @@ -0,0 +1,173 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.encoders
    +
    +
    +import scala.reflect.ClassTag
    +
    +import org.apache.spark.sql.catalyst.InternalRow
    +import org.apache.spark.sql.catalyst.expressions.Attribute
    +import org.apache.spark.sql.types.{StructField, StructType}
    +
    +// Most of this file is codegen.
    +// scalastyle:off
    +
    +/**
    + * A set of composite encoders that take sub encoders and map each of 
their objects to a
    + * Scala tuple.  Note that currently the implementation is fairly limited 
and only supports going
    + * from an internal row to a tuple.
    + */
    +object TupleEncoder {
    --- End diff --
    
    Thats true, but the though was that we wanted some way to compose any 
encoder (i.e. one for Java POJOs) in a way that returns a tuple.  However, I'm 
in the process of rewriting all of this to do it using expression composition 
instead of imperative code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to