Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9273#discussion_r43012950
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala
 ---
    @@ -137,7 +137,7 @@ private[spark] class SparkDeploySchedulerBackend(
     
       override def executorRemoved(fullId: String, message: String, 
exitStatus: Option[Int]) {
         val reason: ExecutorLossReason = exitStatus match {
    -      case Some(code) => ExecutorExited(code, isNormalExit = true, message)
    +      case Some(code) => ExecutorExited(code, isNormalExit = false, 
message)
    --- End diff --
    
    I don't think that's a good idea. The user's code could then 
`System.exit(0)` and mess up accounting of failed tasks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to