Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/9143#discussion_r43040224
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala
---
@@ -122,6 +161,26 @@ private[streaming] class ReceivedBlockTracker(
}
}
+ /**
+ * Allocate all unallocated blocks to the given batch.
+ * This event will get written to the write ahead log (if enabled).
+ */
+ def allocateBlocksToBatch(batchTime: Time): Unit = {
--- End diff --
Why have three versions of every func - e.g. allocateBlocksToBatch,
allocateBlocksToBatchAync, and allocateBlocksToBatch0? Why not have a single
version - allocateBlocksToBatch, which takes an optional parameter async:
Boolean. It will call writeToLog with that parameter, and writeToLog can check
that async parameter to decide what to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
