Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9214#discussion_r43079006
  
    --- Diff: core/src/test/scala/org/apache/spark/SortShuffleSuite.scala ---
    @@ -83,8 +83,8 @@ class SortShuffleSuite extends ShuffleSuite with 
BeforeAndAfterAll {
         shuffledRdd.count()
         // Ensure that the shuffle actually created files that will need to be 
cleaned up
         val filesCreatedByShuffle = getAllFiles -- filesBeforeShuffle
    -    filesCreatedByShuffle.map(_.getName) should be
    -    Set("shuffle_0_0_0.data", "shuffle_0_0_0.index")
    --- End diff --
    
    this wasn't actually testing anything earlier.  It was getting parsed as 
two entirely different statements, due to some wrinkle in the way the `be` 
scalatest construct work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to