Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/9285#discussion_r43079819
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/util/FileBasedWriteAheadLog.scala
---
@@ -47,7 +47,8 @@ private[streaming] class FileBasedWriteAheadLog(
logDirectory: String,
hadoopConf: Configuration,
rollingIntervalSecs: Int,
- maxFailures: Int
+ maxFailures: Int,
+ closeAfterWrite: Boolean = false
--- End diff --
I didn't want to break existing code. Apparently `FileBasedWriteAheadLog`
is instantiated in only 4 spots, therefore I can manually add the
`closeAfterWrite = false` parameter to all of them. It could be okay to keep it
though as the method is private[streaming] and we don't need to keep Java
compatibility as it is not exposed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
