Github user chenghao-intel commented on the pull request:

    https://github.com/apache/spark/pull/9223#issuecomment-151400091
  
    Probably we also need to add the assertion at:
    
    ```scala
    class HadoopFsRelation {
    ...
      final private[sql] def buildScan(
          requiredColumns: Array[String],
          filters: Array[Filter],
          inputPaths: Array[String],
          broadcastedConf: Broadcast[SerializableConfiguration])
    ...
    }
    ```
    
    I'll agree the JsonRelation is not exactly the same case, as we will try to 
infer the schema in another code path. 
    So will that be OK if we add assertion at the `buildScan` in the parent 
class(as above), and also add the assertion at the `override lazy val 
dataSchema = ...` in `JsonRelation`(not the `createBaseRdd`)?
    
    /cc @liancheng 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to