Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9227#discussion_r43096749
--- Diff:
network/common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java
---
@@ -158,6 +158,13 @@ public TransportClient createClient(String remoteHost,
int remotePort) throws IO
}
}
+ /**
+ * Create a completely new {@link TransportClient} to the given remote
host / port */
+ public TransportClient createNewClient(String remoteHost, int
remotePort) throws IOException {
--- End diff --
I actually wanted to add this method for a different change (no PR yet), so
it's welcome. But the javadoc needs to mention that this connection is not
pooled, like the ones returned by `createClient`.
Because of that, I'd also name the method `createUnmanagedClient`, and make
it clear that it's the caller's responsibility to close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
