Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9003#discussion_r43162207
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
 ---
    @@ -991,3 +991,73 @@ case class StddevFunction(
         }
       }
     }
    +
    +// placeholder
    +case class Kurtosis(child: Expression) extends UnaryExpression with 
AggregateExpression {
    +
    +  override def nullable: Boolean = false
    +
    +  override def dataType: DoubleType.type = DoubleType
    +
    +  override def foldable: Boolean = false
    +
    +  override def prettyName: String = "kurtosis"
    +
    +  override def toString: String = s"KURTOSIS($child)"
    +}
    +
    +// placeholder
    +case class Skewness(child: Expression) extends UnaryExpression with 
AggregateExpression {
    +
    +  override def nullable: Boolean = false
    +
    +  override def dataType: DoubleType.type = DoubleType
    +
    +  override def foldable: Boolean = false
    +
    +  override def prettyName: String = "skewness"
    +
    +  override def toString: String = s"SKEWNESS($child)"
    +}
    +
    +// placeholder
    +case class Variance(child: Expression) extends UnaryExpression with 
AggregateExpression {
    +
    +  override def nullable: Boolean = false
    +
    +  override def dataType: DoubleType.type = DoubleType
    +
    +  override def foldable: Boolean = false
    +
    +  override def prettyName: String = "variance"
    +
    +  override def toString: String = s"VARIANCE($child)"
    +}
    +
    +// placeholder
    +case class VariancePop(child: Expression) extends UnaryExpression with 
AggregateExpression {
    +
    +  override def nullable: Boolean = false
    +
    +  override def dataType: DoubleType.type = DoubleType
    +
    +  override def foldable: Boolean = false
    +
    +  override def prettyName: String = "variance_pop"
    +
    +  override def toString: String = s"VAR_POP($child)"
    +}
    +
    +// placeholder
    +case class VarianceSamp(child: Expression) extends UnaryExpression with 
AggregateExpression {
    +
    +  override def nullable: Boolean = false
    +
    +  override def dataType: DoubleType.type = DoubleType
    +
    +  override def foldable: Boolean = false
    +
    +  override def prettyName: String = "variance_samp"
    +
    +  override def toString: String = s"VAR_SAMP($child)"
    +}
    --- End diff --
    
    What will be the error message if we call this function when 
`spark.sql.useAggregate2=false`? It will be good to provide a meaning error 
message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to