Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9183#discussion_r43221732
  
    --- Diff: R/pkg/inst/tests/test_mllib.R ---
    @@ -56,14 +56,3 @@ test_that("feature interaction vs native glm", {
       rVals <- predict(glm(Sepal.Width ~ Species:Sepal.Length, data = iris), 
iris)
       expect_true(all(abs(rVals - vals) < 1e-6), rVals - vals)
     })
    -
    -test_that("summary coefficients match with native glm", {
    --- End diff --
    
    It's not removed, just temporary disable. Because of this PR changed the 
semantics of ```StringIndexer``` a little that cause this test case produce 
indeterminate result. We should first discuss the semantics changing is 
necessary or not, and then we can update the test case to produce determinate 
result.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to