Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/8744#issuecomment-151740814
Hi @steveloughran , looks like this patch is quite large, can we just:
1. Remove some unnecessary getter/setter methods, it is quite Java way and
so verbose in Scala.
2. Group and separate some class parameters into subclasses, it will be
easily error-prone if you have a large mount of mutable parameter to track the
state.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
