Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9330#discussion_r43236937
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala ---
@@ -83,11 +83,12 @@ class GroupedIterator private(
/** Holds a copy of an input row that is in the current group. */
var currentGroup = currentRow.copy()
- var currentIterator: Iterator[InternalRow] = null
+
assert(keyOrdering.compare(currentGroup, currentRow) == 0)
--- End diff --
Looks like we only use `keyOrdering` to do equality check, why not just use
`==`? The `currentGroup` and `currentRow` are from the same input, they must be
both unsafe or safe, and `==` for `UnsafeRow` is faster than
`keyOrdering.compare`.
cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
