Github user mattf commented on the pull request:

    https://github.com/apache/spark/pull/1216#issuecomment-47306081
  
    instead of set +e/-e, i'd suggest "git rev-parse || :" and then construct 
the GITREVSTRING on a positive "test -n" result
    
    however, the code works as presented


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to