Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/9143#discussion_r43336812
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala
---
@@ -73,6 +79,18 @@ private[streaming] class ReceivedBlockTracker(
private val streamIdToUnallocatedBlockQueues = new mutable.HashMap[Int,
ReceivedBlockQueue]
private val timeToAllocatedBlocks = new mutable.HashMap[Time,
AllocatedBlocks]
private val writeAheadLogOption = createWriteAheadLog()
+ // exposed for tests
+ protected val walWriteQueue = new
LinkedBlockingQueue[ReceivedBlockTrackerLogEvent]()
--- End diff --
Rather than have the corresponding promise in another map, why not just
keep the event+promise in the queue? Wouldnt it be a simpler design?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
