Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/9206#discussion_r43395471
--- Diff:
network/common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
---
@@ -50,6 +55,8 @@
private final Map<Long, RpcResponseCallback> outstandingRpcs;
+ private final Queue<StreamCallback> streamCallbacks;
--- End diff --
I see. this is why the `synchronized` block is in
`TransportClient#stream`? would be good to add a comment explaining that
(maybe even something brief in both places).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
