Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9364#discussion_r43452264
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
    @@ -663,6 +667,35 @@ class DataFrame private[sql](
       def orderBy(sortExprs: Column*): DataFrame = sort(sortExprs : _*)
     
       /**
    +   * Returns a new [[DataFrame]] partitioned by the given partitioning 
expressions into
    +   * `numPartitions`
    +   * `numPartitions` can be < 0 to preserve the current number of 
partitions.
    +   * @group dfops
    +   * @since 1.6.0
    +   */
    +  def distributeBy(partitionExprs: Seq[Column], numPartitions: Int = -1): 
DataFrame = {
    +    PartitionByExpression(partitionExprs.map { _.expr }, logicalPlan, 
numPartitions)
    +  }
    --- End diff --
    
    Let's avoid of having default value in the public API (see 
https://github.com/databricks/scala-style-guide#java-default-param-values). We 
can overload this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to