Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/9204#issuecomment-152415593 @haoyuan hey HY - can you not merge build related patches without asking for feedback from one of the build maintainers (me or @srowen)? This patch makes changes to Spark's dependency graph that need to be audited carefully because they affect all users. There is discussion of the maintainer/review process here: https://cwiki.apache.org/confluence/display/SPARK/Committers#Committers-ReviewProcessandMaintainers I did a post hoc review and it appears this does not change the contents of the assembly jar. So I think it is okay. Separately, it would be good to spin tachyon support out into a package so these changes do not need to go through the upstream review process.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org