Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43477553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +168,55 @@ abstract class Star extends LeafExpression with
NamedExpression {
* Represents all of the input attributes to a given relational operator,
for example in
* "SELECT * FROM ...".
*
- * @param table an optional table that should be the target of the
expansion. If omitted all
- * tables' columns are produced.
+ * This is also used to expand structs. For example:
+ * "SELECT record.* from (SELCCT struct(a,b,c) as record ...)
+ *
+ * @param target an optional name that should be the target of the
expansion. If omitted all
+ * targets' columns are produced. This can either be a table
name or struct name.
*/
-case class UnresolvedStar(table: Option[String]) extends Star with
Unevaluable {
+case class UnresolvedStar(target: Option[String]) extends Star with
Unevaluable {
--- End diff --
How about `table.structColumn.*`? or `complexColumn.structField.*`? I think
a `Option[String]` is not enough to express this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
