Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/9399#issuecomment-152910627
Actually I am talking that it probably give us some troubles in getting the
`unhandledFilters` if we planned to optimize the cases where partition keys
combined in the filter, as the partition key will be constant value during the
execution for EACH PARTITION, and we may not able to make it filterable in
planning stage, at least the code will be more complicated, and besides, I
don't see too much benefit if we exposed the `unhandledFilters` for
`DataSourceStrategy`, so I am suggesting if we can leave the `unhandledFilters`
for `buildScan`, as `unhandledFilters` can be considered as a private/protected
method in `BaseRelation`, or we can provide some common operation helper
functions to simplify the implementation for the new data source developers.
Sorry if I missed something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
