Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/9393#discussion_r43603749
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -30,13 +30,16 @@ case class ScalaUDF(
function: AnyRef,
dataType: DataType,
children: Seq[Expression],
- inputTypes: Seq[DataType] = Nil)
+ inputTypes: Seq[DataType] = Nil,
+ isDeterministic: Boolean = true)
extends Expression with ImplicitCastInputTypes with CodegenFallback {
override def nullable: Boolean = true
override def toString: String = s"UDF(${children.mkString(",")})"
+ override def deterministic: Boolean = isDeterministic &&
children.forall(_.deterministic)
--- End diff --
We probably need to override the `foldable` as well. Something like:
```scala
override def foldable: Boolean = deterministic &&
children.forall(_.foldable)
```
Or change it in `Expression` directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
