Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9299#issuecomment-152963689
I don't think the fact that one of the values is immutable matters. There
are two copies of the same value within the same object (in `ApplicationInfo`
and in the `ApplicationDescription` inside it) one of which never changes and
one of which changes. Both have the same name. They may diverge in value
(right?) This seems confusing. Can we do anything with naming or comments to
clarify?
So maybe `ApplicationInfo` should indeed rename its field to ... yes,
`appUIOrPlaceholderURI` or something? Maybe it can be decomposed further:
`ApplicationInfo` can have a "placeholder" or "override" `Option[String]` field
whose value is returned if it exists or else the value from
`ApplicationDescription` is returned? Maybe I'm over-thinking that. But it
seems like we can add a little more clarity here to avoid, say, someone later
accessing `ApplicationInfo.ApplicationDescription.appUiUri` and not realizing
it's not the current, possibly-overridden value like it used to be.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
