Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9419#discussion_r43681600
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -240,10 +240,52 @@ class Analyzer(
               x.child
             }
     
    +        // We will insert another Projection if the GROUP BY keys are 
contained in the
    --- End diff --
    
    Maybe in addition to describing what we do we should explain why we are 
inserting this projection here as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to