Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9218#discussion_r43694062
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -276,6 +276,75 @@ setMethod("names<-",
                 }
               })
     
    +#' @rdname columns
    +#' @name colnames
    +setMethod("colnames",
    +          signature(x = "DataFrame"),
    +          function(x) {
    +            columns(x)
    +          })
    +
    +#' @rdname columns
    +#' @name colnames<-
    +setMethod("colnames<-",
    +          signature(x = "DataFrame", value = "character"),
    +          function(x, value) {
    +            sdf <- callJMethod(x@sdf, "toDF", as.list(value))
    --- End diff --
    
    I tried actually but couldn't get that to work - it ended up calling 
names<- of data.frame.
    Since this is one line I thought it's ok this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to