Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9344#discussion_r43697998
--- Diff:
core/src/test/scala/org/apache/spark/memory/UnifiedMemoryManagerSuite.scala ---
@@ -163,18 +170,19 @@ class UnifiedMemoryManagerSuite extends
MemoryManagerSuite with PrivateMethodTes
test("storage does not evict execution") {
val maxMemory = 1000L
+ val taskAttemptId = 0L
val (mm, ms) = makeThings(maxMemory)
// First, ensure the test classes are set up as expected
val expectedStorageRegionSize = 500L
val expectedExecutionRegionSize = 500L
- val storageRegionSize = getStorageRegionSize(mm)
+// val storageRegionSize = getStorageRegionSize(mm)
val executionRegionSize = maxMemory - expectedStorageRegionSize
- require(storageRegionSize === expectedStorageRegionSize,
- "bad test: storage region size is unexpected")
+// require(storageRegionSize === expectedStorageRegionSize,
--- End diff --
I don't think that we need these asserts anymore since these invariants are
checked via assertions inside of the pool itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
