Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1165#discussion_r14324964
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -61,9 +61,9 @@ private[spark] class BlockManager(
     
       // Actual storage of where blocks are kept
       private var tachyonInitialized = false
    -  private[storage] val memoryStore = new MemoryStore(this, maxMemory)
    -  private[storage] val diskStore = new DiskStore(this, diskBlockManager)
    -  private[storage] lazy val tachyonStore: TachyonStore = {
    +  private[spark] val memoryStore = new MemoryStore(this, maxMemory)
    +  private[spark] val diskStore = new DiskStore(this, diskBlockManager)
    +  private[spark] lazy val tachyonStore: TachyonStore = {
    --- End diff --
    
    We dont need to relax visibility of diskStore and tachyonStore - I did not 
see them being used ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to