Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43715153
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -60,7 +60,8 @@ class Column(protected[sql] val expr: Expression) extends
Logging {
def this(name: String) = this(name match {
case "*" => UnresolvedStar(None)
- case _ if name.endsWith(".*") => UnresolvedStar(Some(name.substring(0,
name.length - 2)))
+ case _ if name.endsWith(".*") =>
UnresolvedStar(Some(UnresolvedAttribute.parseAttributeName(
+ name.substring(0, name.length - 2))))
--- End diff --
How about we create a local val to make this part of code easy to
understand?
e.g.
```
val nameParts = UnresolvedAttribute.parseAttributeName(name.substring(0,
name.length - 2))
UnresolvedStar(Some(nameParts))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
