Github user suyanNone commented on the pull request:
https://github.com/apache/spark/pull/8923#issuecomment-153248553
@markhamstra @squito
I need re-construct and re-run the test case to confirm that problem...
R1 --|
| --->R3 | --------> R4 --|
| |---->R6--->R7
R2 --| R3 |--------->R5 --|
We get finalRDD: R7 shufflesdeps, the first is R6
for R6, not added into `shuffleToMapStage`, get his all not added into
`shuffleIdToMapStage` AncestersDeps (R4(R3(R1, R2)), R5(R3(R1, R2))), in Stack
it somthing like(R4, R3, R1, R2, R5, R3, R1, R2), for each dep, it will
create a new ShuffleMapStage. so the deps from R1->R3 and R2 ->R3, will create
twice.
eh... @markhamstra, change the return type from Stack to Set sounds like
good, but the `shuffleDep` object, I not sure it is unique for each shuffleId,
I need to check that. If I confirm that uniq, I'd like to change the `val
parents = new Stack[ShuffleDependency[_, _, _]]` to `new Set`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
