Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9399#discussion_r43719128
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -409,7 +439,48 @@ private[sql] object DataSourceStrategy extends
Strategy with Logging {
case _ => None
}
+ }
+
+ /**
+ * Selects Catalyst predicate [[Expression]]s which are convertible into
data source [[Filter]]s
+ * and can be handled by `relation`.
+ *
+ * @return A pair of `Seq[Expression]` and `Seq[Filter]`. The first
element contains all Catalyst
+ * predicate [[Expression]]s that are either not convertible or
cannot be handled by
+ * `relation`. The second element contains all converted data
source [[Filter]]s.
--- End diff --
I think we need to emphasize that the second element does contain `Filter`s
that will be reject by the data source.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
