Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9403#discussion_r43850884
  
    --- Diff: 
extras/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisStreamSuite.scala
 ---
    @@ -56,6 +56,8 @@ class KinesisStreamSuite extends KinesisFunSuite
       private var ssc: StreamingContext = null
       private var sc: SparkContext = null
     
    +  protected val aggregateTestData: Boolean
    --- End diff --
    
    Isn it easier to have a parameter in the constructor? Less code while 
subclassing `class WithAggregationKinesisStreamSuite extends 
KinesisStreamTests(true)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to