Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9448#discussion_r43859820
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
    @@ -143,14 +143,10 @@ private[spark] object UIUtils extends Logging {
     
       // Yarn has to go through a proxy so the base uri is provided and has to 
be on all links
       def uiRoot: String = {
    -    if (System.getenv("APPLICATION_WEB_PROXY_BASE") != null) {
    -      System.getenv("APPLICATION_WEB_PROXY_BASE")
    -    } else if (System.getProperty("spark.ui.proxyBase") != null) {
    -      System.getProperty("spark.ui.proxyBase")
    -    }
    -    else {
    -      ""
    -    }
    +    // SPARK-11484 - Use the proxyBase set by the AM, if not found then 
use env.
    --- End diff --
    
    I think this ultimately makes sense, letting Spark-specific stuff take 
precedence, though it's worth enumerating here or in the JIRA why this is 
connected to Oozie / uber mode, and why this is right-er than the current 
behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to