Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/9313#discussion_r43909305
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1667,6 +1673,13 @@ class SparkContext(config: SparkConf) extends
Logging with ExecutorAllocationCli
if (key != null) {
addedJars(key) = System.currentTimeMillis
logInfo("Added JAR " + path + " at " + key + " with timestamp " +
addedJars(key))
+ if (addToCurrentThread) {
+ val currentCL = Utils.getContextOrSparkClassLoader
+ currentCL match {
+ case cl: MutableURLClassLoader => cl.addURL(new
URI(key).toURL())
+ case _ => logWarning(s"Unsupported cl $currentCL will not
update jars thread cl")
--- End diff --
My opinion is that it's better to throw an exception here. Though as that's
an API behavior question, probably best to defer to a core maintainer?
@pwendell any thoughts? And thoughts on adding this option to addJar in general?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
